From 9ae248d5f7c83cba1a9ddb227fd311afda04ca4a Mon Sep 17 00:00:00 2001
From: Paul Payne <paul@payne.io>
Date: Tue, 5 Aug 2025 17:40:56 -0700
Subject: [PATCH] Updates secret handling in wild-app-deploy.

---
 bin/wild-app-deploy | 30 ------------------------------
 1 file changed, 30 deletions(-)

diff --git a/bin/wild-app-deploy b/bin/wild-app-deploy
index 8813300..f0034bf 100755
--- a/bin/wild-app-deploy
+++ b/bin/wild-app-deploy
@@ -84,9 +84,6 @@ deploy_secrets() {
     while IFS= read -r secret_path; do
         secret_value=$(yq eval ".${secret_path} // \"\"" "${SECRETS_FILE}")
         if [ -n "${secret_value}" ] && [ "${secret_value}" != "null" ]; then
-            if [[ "${secret_value}" == CHANGE_ME_* ]]; then
-                echo "Warning: Secret '${secret_path}' for app '${app_name}' still has dummy value: ${secret_value}"
-            fi
             secret_data="${secret_data} --from-literal=${secret_path}=${secret_value}"
         else
             echo "Error: Required secret '${secret_path}' not found in ${SECRETS_FILE} for app '${app_name}'"
@@ -100,7 +97,6 @@ deploy_secrets() {
         if [ "${DRY_RUN:-}" = "--dry-run=client" ]; then
             echo "DRY RUN: kubectl create secret generic ${app_name}-secrets ${secret_data} --namespace=${namespace} --dry-run=client -o yaml"
         else
-            # Delete existing secret if it exists, then create new one
             kubectl delete secret "${app_name}-secrets" --namespace="${namespace}" --ignore-not-found=true
             kubectl create secret generic "${app_name}-secrets" ${secret_data} --namespace="${namespace}"
         fi
@@ -149,32 +145,6 @@ if [ -f "apps/${APP_NAME}/namespace.yaml" ]; then
     wild-cluster-secret-copy cert-manager:wildcard-wild-cloud-tls "$NAMESPACE" || echo "Warning: Failed to copy external wildcard certificate"
 fi
 
-# Step 2: Deploy secrets (dependencies and main app)
-echo "Deploying secrets..."
-if [ -f "${MANIFEST_FILE}" ]; then
-    if yq eval '.requires' "${MANIFEST_FILE}" | grep -q -v '^null$'; then
-        echo "Deploying secrets for required dependencies..."
-        yq eval '.requires[].name' "${MANIFEST_FILE}" | while read -r required_app; do
-            if [ -z "${required_app}" ] || [ "${required_app}" = "null" ]; then
-                echo "Warning: Empty or null dependency found, skipping"
-                continue
-            fi
-            
-            if [ ! -d "apps/${required_app}" ]; then
-                echo "Error: Required dependency '${required_app}' not found in apps/ directory"
-                exit 1
-            fi
-            
-            echo "Deploying secrets for dependency: ${required_app}"
-            # Deploy secrets in dependency's own namespace
-            deploy_secrets "${required_app}"
-            # Also deploy dependency secrets in consuming app's namespace
-            echo "Copying dependency secrets to app namespace: ${APP_NAME}"
-            deploy_secrets "${required_app}" "${APP_NAME}"
-        done
-    fi
-fi
-
 # Deploy secrets for this app
 deploy_secrets "${APP_NAME}"