Paul Payne
428d47f876
Architecture: - Extract reconcileNetworking into internal/reconcile package with 7 consumer-side interfaces - Add locked modifyState helper to fix state.yaml read-modify-write race condition - Extract CrowdSec and VPN handler groups with interfaces documenting dependency surface - Replace raw map[string]any YAML manipulation with typed AddDHCPStaticLease/RemoveDHCPStaticLease - Extract Cloudflare API functions into cfClient struct, eliminating repeated auth boilerplate Complexity reduction: - haproxy.GenerateWithOpts: 50 → 6 (extracted 8 focused helpers) - reconcile.Reconcile: 42 → 11 (extracted buildRoutes, buildDNSEntries, writeHAProxyConfig) - AutheliaUpdateConfig: 25 → 10 (extracted enableAuthelia/disableAuthelia) Test coverage improvements: - reconcile: 4.5% → 56.8% (stub-based tests for route building, DNS entries, orchestration) - dnsfilter: 10.7% → 45.6% (Manager.Compile, AddList, ToggleList, custom entries) - config: 67.3% → 89.8% (DHCP static lease mutation tests)
36 lines
1.2 KiB
Go
36 lines
1.2 KiB
Go
package v1
|
|
|
|
import (
|
|
"encoding/json"
|
|
"net/http"
|
|
)
|
|
|
|
// APIResponse is the standard response envelope for all API endpoints.
|
|
// All successful responses wrap data in the Data field.
|
|
// Error responses use the Error field.
|
|
// Message-only responses use the Message field.
|
|
type APIResponse struct {
|
|
Data any `json:"data,omitempty"`
|
|
Message string `json:"message,omitempty"`
|
|
Error string `json:"error,omitempty"`
|
|
}
|
|
|
|
// respondJSON writes a JSON response with the given status code.
|
|
// This is the low-level helper that all other response helpers use.
|
|
func respondJSON(w http.ResponseWriter, status int, data any) {
|
|
w.Header().Set("Content-Type", "application/json")
|
|
w.WriteHeader(status)
|
|
_ = json.NewEncoder(w).Encode(data)
|
|
}
|
|
|
|
// respondMessage writes a success response with only a message (no data).
|
|
// Use this for operations that succeed but don't return meaningful data.
|
|
func respondMessage(w http.ResponseWriter, status int, message string) {
|
|
respondJSON(w, status, APIResponse{Message: message})
|
|
}
|
|
|
|
// respondError writes an error response with the given status code and message.
|
|
func respondError(w http.ResponseWriter, status int, message string) {
|
|
respondJSON(w, status, APIResponse{Error: message})
|
|
}
|