Files
wild-central/internal/api/v1/handlers_config_test.go
Paul Payne 60f3ca4a3a Security hardening: input validation, secrets protection, NATS auth
Config injection prevention:
- Add FQDN validation for domain names (RFC 1123) in Register/Update —
  rejects newlines, spaces, shell metacharacters that could inject into
  HAProxy/dnsmasq configs
- Add backend address validation (valid host:port format, valid IP or
  hostname, port 1-65535). DNS-only backends allow bare IPs.
- Add header key/value validation — keys must be HTTP token chars only,
  values must not contain newlines or NULs
- Add WireGuard peer name validation (alphanumeric + hyphens + underscores)
- Add defense-in-depth domain validation in certbot Provision()

Secrets protection:
- Remove ?raw=true bypass on GET /api/v1/secrets — secrets are now always
  redacted in API responses regardless of query parameters
- Update test to verify redaction cannot be bypassed

NATS authentication:
- Generate random auth token on first startup, store in secrets.yaml
- Pass token to embedded NATS server via Authorization option
- Internal client connects with the same token
- External NATS clients (Wild Cloud) must now authenticate

Security headers:
- Add X-Content-Type-Options: nosniff
- Add X-Frame-Options: DENY
- Add Cache-Control: no-store
2026-07-14 12:38:17 +00:00

186 lines
4.7 KiB
Go

package v1
import (
"bytes"
"encoding/json"
"net/http"
"net/http/httptest"
"os"
"path/filepath"
"testing"
"gopkg.in/yaml.v3"
)
func TestGetOperator(t *testing.T) {
api, tmpDir := setupTestAPI(t)
// Write state with operator email
state := map[string]any{
"operator": map[string]any{"email": "test@example.com"},
}
data, _ := yaml.Marshal(state)
os.WriteFile(filepath.Join(tmpDir, "state.yaml"), data, 0644)
req := httptest.NewRequest("GET", "/api/v1/operator", nil)
w := httptest.NewRecorder()
api.GetOperator(w, req)
if w.Code != http.StatusOK {
t.Fatalf("expected 200, got %d: %s", w.Code, w.Body.String())
}
var resp map[string]any
json.Unmarshal(w.Body.Bytes(), &resp)
if resp["email"] != "test@example.com" {
t.Errorf("expected email test@example.com, got %v", resp["email"])
}
}
func TestUpdateOperator(t *testing.T) {
api, tmpDir := setupTestAPI(t)
body, _ := json.Marshal(map[string]string{"email": "new@example.com"})
req := httptest.NewRequest("PUT", "/api/v1/operator", bytes.NewReader(body))
w := httptest.NewRecorder()
api.UpdateOperator(w, req)
if w.Code != http.StatusOK {
t.Fatalf("expected 200, got %d: %s", w.Code, w.Body.String())
}
// Verify persisted
data, _ := os.ReadFile(filepath.Join(tmpDir, "state.yaml"))
var state map[string]any
yaml.Unmarshal(data, &state)
op := state["operator"].(map[string]any)
if op["email"] != "new@example.com" {
t.Errorf("expected email new@example.com, got %v", op["email"])
}
}
func TestGetCentralDomain(t *testing.T) {
api, tmpDir := setupTestAPI(t)
state := map[string]any{
"cloud": map[string]any{
"central": map[string]any{"domain": "central.example.com"},
},
}
data, _ := yaml.Marshal(state)
os.WriteFile(filepath.Join(tmpDir, "state.yaml"), data, 0644)
req := httptest.NewRequest("GET", "/api/v1/central-domain", nil)
w := httptest.NewRecorder()
api.GetCentralDomain(w, req)
if w.Code != http.StatusOK {
t.Fatalf("expected 200, got %d", w.Code)
}
var resp map[string]any
json.Unmarshal(w.Body.Bytes(), &resp)
if resp["domain"] != "central.example.com" {
t.Errorf("expected domain central.example.com, got %v", resp["domain"])
}
}
func TestUpdateCentralDomain(t *testing.T) {
api, _ := setupTestAPI(t)
body, _ := json.Marshal(map[string]string{"domain": "new.example.com"})
req := httptest.NewRequest("PUT", "/api/v1/central-domain", bytes.NewReader(body))
w := httptest.NewRecorder()
api.UpdateCentralDomain(w, req)
if w.Code != http.StatusOK {
t.Fatalf("expected 200, got %d: %s", w.Code, w.Body.String())
}
var resp map[string]any
json.Unmarshal(w.Body.Bytes(), &resp)
if resp["domain"] != "new.example.com" {
t.Errorf("expected domain new.example.com, got %v", resp["domain"])
}
}
func TestGetGlobalSecrets_RedactsLeafValues(t *testing.T) {
api, tmpDir := setupTestAPI(t)
secrets := map[string]any{
"cloudflare": map[string]any{
"apiToken": "super-secret-token",
"zoneId": "zone-123",
},
"topLevelSecret": "another-secret",
}
data, _ := yaml.Marshal(secrets)
os.WriteFile(filepath.Join(tmpDir, "secrets.yaml"), data, 0600)
req := httptest.NewRequest("GET", "/api/v1/secrets", nil)
w := httptest.NewRecorder()
api.GetGlobalSecrets(w, req)
var resp map[string]any
json.Unmarshal(w.Body.Bytes(), &resp)
if resp["topLevelSecret"] != "********" {
t.Errorf("expected topLevelSecret redacted, got %v", resp["topLevelSecret"])
}
cf, ok := resp["cloudflare"].(map[string]any)
if !ok {
t.Fatalf("expected cloudflare to be a map, got %T", resp["cloudflare"])
}
if cf["apiToken"] != "********" {
t.Errorf("expected apiToken redacted, got %v", cf["apiToken"])
}
}
func TestGetGlobalSecrets_AlwaysRedacted(t *testing.T) {
api, tmpDir := setupTestAPI(t)
secrets := map[string]any{
"cloudflare": map[string]any{
"apiToken": "my-token",
},
}
data, _ := yaml.Marshal(secrets)
os.WriteFile(filepath.Join(tmpDir, "secrets.yaml"), data, 0600)
// Even with ?raw=true, secrets must be redacted (bypass removed for security)
req := httptest.NewRequest("GET", "/api/v1/secrets?raw=true", nil)
w := httptest.NewRecorder()
api.GetGlobalSecrets(w, req)
var resp map[string]any
json.Unmarshal(w.Body.Bytes(), &resp)
cf := resp["cloudflare"].(map[string]any)
if cf["apiToken"] == "my-token" {
t.Error("expected apiToken to be redacted, but got raw value")
}
}
func TestCloudflareVerify_NoToken(t *testing.T) {
api, _ := setupTestAPI(t)
req := httptest.NewRequest("GET", "/api/v1/cloudflare/verify", nil)
w := httptest.NewRecorder()
api.CloudflareVerify(w, req)
if w.Code != http.StatusOK {
t.Fatalf("expected 200, got %d", w.Code)
}
var resp map[string]any
json.Unmarshal(w.Body.Bytes(), &resp)
if resp["tokenConfigured"] != false {
t.Errorf("expected tokenConfigured=false with no secrets, got %v", resp["tokenConfigured"])
}
}