Paul Payne
1bc41ddd2d
save_config rewrites castle.yaml from scratch and only re-emitted gateway/repo/ roots — so any config save (dashboard deployment edit, config_editor) silently STRIPPED top-level 'role' and the 'secrets:' backend block. Effect: the node reverted to a file-backend follower, the vault stopped resolving, and a subsequent apply baked <MISSING_SECRET> into service env (hit castle-lakehouse). Now re-emit role (from config) + preserve the secrets block (read from the existing file, since it's not modeled on CastleConfig). Regression test added.
70 lines
2.2 KiB
Python
70 lines
2.2 KiB
Python
"""Fleet role (authority/follower) — config loading + registry round-trip."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
|
|
import yaml
|
|
from castle_core.config import load_config
|
|
from castle_core.registry import (
|
|
NodeConfig,
|
|
NodeRegistry,
|
|
load_registry,
|
|
save_registry,
|
|
)
|
|
|
|
|
|
def _write_min_config(root: Path, role: str | None) -> None:
|
|
data: dict = {"gateway": {"port": 18000}}
|
|
if role is not None:
|
|
data["role"] = role
|
|
(root / "castle.yaml").write_text(yaml.safe_dump(data))
|
|
|
|
|
|
def test_role_defaults_to_follower(tmp_path: Path) -> None:
|
|
_write_min_config(tmp_path, None)
|
|
assert load_config(tmp_path).role == "follower"
|
|
|
|
|
|
def test_role_loaded_from_yaml(tmp_path: Path) -> None:
|
|
_write_min_config(tmp_path, "authority")
|
|
assert load_config(tmp_path).role == "authority"
|
|
|
|
|
|
def test_save_config_round_trips_role_and_secrets(tmp_path: Path) -> None:
|
|
"""save_config rewrites castle.yaml from scratch — it must re-emit `role` and
|
|
preserve the `secrets:` block, or a save reverts the node to a file-backend
|
|
follower (the regression this guards)."""
|
|
from castle_core.config import load_config, save_config
|
|
|
|
(tmp_path / "castle.yaml").write_text(
|
|
yaml.safe_dump(
|
|
{
|
|
"gateway": {"port": 18000},
|
|
"role": "authority",
|
|
"secrets": {"backend": "openbao", "addr": "https://v:8200"},
|
|
}
|
|
)
|
|
)
|
|
save_config(load_config(tmp_path))
|
|
reloaded = yaml.safe_load((tmp_path / "castle.yaml").read_text())
|
|
assert reloaded.get("role") == "authority"
|
|
assert reloaded.get("secrets", {}).get("backend") == "openbao"
|
|
|
|
|
|
def test_registry_role_round_trip(tmp_path: Path) -> None:
|
|
reg = NodeRegistry(
|
|
node=NodeConfig(hostname="civil", role="authority"), deployed={}
|
|
)
|
|
path = tmp_path / "registry.yaml"
|
|
save_registry(reg, path)
|
|
assert load_registry(path).node.role == "authority"
|
|
|
|
|
|
def test_registry_role_defaults_follower(tmp_path: Path) -> None:
|
|
"""A node with no explicit role round-trips as follower."""
|
|
reg = NodeRegistry(node=NodeConfig(hostname="n"), deployed={})
|
|
path = tmp_path / "registry.yaml"
|
|
save_registry(reg, path)
|
|
assert load_registry(path).node.role == "follower"
|