The `castle` CLI and the `castle-api` service are two independent in-process drivers of `castle_core`. Each resolved DATA_DIR/REPOS_DIR at import time from its own process env (default /data/castle), persisted nowhere — so they silently diverged, and `apply`/dashboard-apply crashed on a non-existent /data. Make the loaded CastleConfig the single source of truth: - Resolve data_dir/repos_dir only in load_config (env > castle.yaml > default), anchored to the config root; drop the DATA_DIR/REPOS_DIR module globals and the import-time file read entirely — no global twin that can disagree with the file. - Thread config.data_dir/repos_dir through ensure_dirs, _env_context, tls_dir_for (now unified — deploy no longer inlines the tls path), and create/add/clone. - ensure_dirs raises an actionable CastleDirError instead of a bare PermissionError; the api surfaces it as 422. - doctor: "data dir writable" check + WARN when CASTLE_DATA_DIR/REPOS_DIR env overrides the file (the one remaining cross-process divergence vector). - install.sh persists data_dir/repos_dir into castle.yaml (idempotent, non-default). - Docs: registry.md globals + AGENTS.md roots. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
129 lines
4.8 KiB
Python
129 lines
4.8 KiB
Python
"""Tests for castle-managed TLS material (core/src/castle_core/tls.py)."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
import castle_core.config as C
|
|
import castle_core.tls as T
|
|
from castle_core.manifest import SystemdDeployment
|
|
|
|
|
|
def _write_wildcard(xdg: Path, domain: str, tag: str, acme_dir: str) -> None:
|
|
d = xdg / "caddy" / "certificates" / acme_dir / f"wildcard_.{domain}"
|
|
d.mkdir(parents=True, exist_ok=True)
|
|
(d / f"wildcard_.{domain}.crt").write_bytes(f"CERT-{tag}\n".encode())
|
|
(d / f"wildcard_.{domain}.key").write_bytes(f"KEY-{tag}\n".encode())
|
|
|
|
|
|
@pytest.fixture
|
|
def tls_env(tmp_path: Path, monkeypatch: pytest.MonkeyPatch):
|
|
"""Isolate Caddy's cert store (XDG_DATA_HOME, read live) to a temp dir. The data
|
|
dir is carried on the config (config.data_dir) — the single source of truth — and
|
|
returned so tests can locate materialized certs via tls_dir_for(data_dir, ...)."""
|
|
domain = "civil.payne.io"
|
|
xdg = tmp_path / "xdg"
|
|
_write_wildcard(xdg, domain, "PROD", "acme-v02.api.letsencrypt.org-directory")
|
|
_write_wildcard(
|
|
xdg, domain, "STAGING", "acme-staging-v02.api.letsencrypt.org-directory"
|
|
)
|
|
monkeypatch.setenv("XDG_DATA_HOME", str(xdg))
|
|
return T, C, domain, tmp_path / "data"
|
|
|
|
|
|
def _cfg(C, domain, dep, data_dir):
|
|
return C.CastleConfig(
|
|
root=None,
|
|
gateway=C.GatewayConfig(port=9000, domain=domain),
|
|
repo=None,
|
|
programs={},
|
|
data_dir=data_dir,
|
|
deployments={"postgres": dep},
|
|
)
|
|
|
|
|
|
def _pg(material: str):
|
|
return SystemdDeployment.model_validate(
|
|
{
|
|
"manager": "systemd",
|
|
"program": "postgres",
|
|
"run": {"launcher": "container", "image": "postgres:17"},
|
|
"reach": "internal",
|
|
"expose": {"tcp": {"port": 5432, "tls": {"material": material}}},
|
|
}
|
|
)
|
|
|
|
|
|
def test_prefers_prod_over_staging(tls_env) -> None:
|
|
T, _, domain, _dd = tls_env
|
|
crt, _ = T.wildcard_cert(domain)
|
|
assert crt.read_text().strip() == "CERT-PROD"
|
|
|
|
|
|
def test_pair_material_and_idempotency(tls_env) -> None:
|
|
T, C, domain, dd = tls_env
|
|
pg = _pg("pair")
|
|
cfg = _cfg(C, domain, pg, dd)
|
|
assert T.materialize_tls(cfg, "postgres", pg) is True # first write
|
|
assert T.materialize_tls(cfg, "postgres", pg) is False # idempotent
|
|
td = T.tls_dir_for(dd, "postgres")
|
|
assert sorted(p.name for p in td.iterdir()) == ["cert.pem", "chain.pem", "key.pem"]
|
|
assert (td / "cert.pem").read_text().strip() == "CERT-PROD"
|
|
assert oct((td / "key.pem").stat().st_mode)[-3:] == "600" # secret
|
|
assert oct((td / "cert.pem").stat().st_mode)[-3:] == "644" # public
|
|
|
|
|
|
def test_material_switch_cleans_stale(tls_env) -> None:
|
|
T, C, domain, dd = tls_env
|
|
pair = _pg("pair")
|
|
T.materialize_tls(_cfg(C, domain, pair, dd), "postgres", pair)
|
|
combined = _pg("combined")
|
|
assert (
|
|
T.materialize_tls(_cfg(C, domain, combined, dd), "postgres", combined) is True
|
|
)
|
|
td = T.tls_dir_for(dd, "postgres")
|
|
assert sorted(p.name for p in td.iterdir()) == ["chain.pem", "combined.pem"]
|
|
assert (td / "combined.pem").read_text() == "KEY-PROD\nCERT-PROD\n" # key + cert
|
|
assert oct((td / "combined.pem").stat().st_mode)[-3:] == "600"
|
|
|
|
|
|
def test_pair_chain_is_issuer_not_leaf(tls_env, tmp_path) -> None:
|
|
"""`chain.pem` (${tls_ca}) is the issuer chain — the intermediates only, leaf
|
|
stripped — so it's a real CA bundle distinct from the leaf-bearing cert.pem
|
|
(regression: they used to be byte-identical)."""
|
|
T, C, domain, dd = tls_env
|
|
leaf = b"-----BEGIN CERTIFICATE-----\nLEAF\n-----END CERTIFICATE-----\n"
|
|
inter = b"-----BEGIN CERTIFICATE-----\nINTERMEDIATE\n-----END CERTIFICATE-----\n"
|
|
crt_dir = (
|
|
Path(tmp_path)
|
|
/ "xdg"
|
|
/ "caddy"
|
|
/ "certificates"
|
|
/ "acme-v02.api.letsencrypt.org-directory"
|
|
/ f"wildcard_.{domain}"
|
|
)
|
|
(crt_dir / f"wildcard_.{domain}.crt").write_bytes(leaf + inter)
|
|
pg = _pg("pair")
|
|
assert T.materialize_tls(_cfg(C, domain, pg, dd), "postgres", pg) is True
|
|
td = T.tls_dir_for(dd, "postgres")
|
|
assert (td / "cert.pem").read_bytes() == leaf + inter # server presents leaf+chain
|
|
assert (td / "chain.pem").read_bytes() == inter # CA bundle = intermediates
|
|
assert (td / "cert.pem").read_bytes() != (td / "chain.pem").read_bytes()
|
|
|
|
|
|
def test_material_off_is_noop(tls_env) -> None:
|
|
T, C, domain, dd = tls_env
|
|
off = SystemdDeployment.model_validate(
|
|
{
|
|
"manager": "systemd",
|
|
"program": "postgres",
|
|
"run": {"launcher": "container", "image": "postgres:17"},
|
|
"reach": "internal",
|
|
"expose": {"tcp": {"port": 5432}},
|
|
}
|
|
)
|
|
assert T.materialize_tls(_cfg(C, domain, off, dd), "postgres", off) is False
|
|
assert not T.tls_dir_for(dd, "postgres").exists()
|