payneio
340f469b3d
The `castle` CLI and the `castle-api` service are two independent in-process drivers of `castle_core`. Each resolved DATA_DIR/REPOS_DIR at import time from its own process env (default /data/castle), persisted nowhere — so they silently diverged, and `apply`/dashboard-apply crashed on a non-existent /data. Make the loaded CastleConfig the single source of truth: - Resolve data_dir/repos_dir only in load_config (env > castle.yaml > default), anchored to the config root; drop the DATA_DIR/REPOS_DIR module globals and the import-time file read entirely — no global twin that can disagree with the file. - Thread config.data_dir/repos_dir through ensure_dirs, _env_context, tls_dir_for (now unified — deploy no longer inlines the tls path), and create/add/clone. - ensure_dirs raises an actionable CastleDirError instead of a bare PermissionError; the api surfaces it as 422. - doctor: "data dir writable" check + WARN when CASTLE_DATA_DIR/REPOS_DIR env overrides the file (the one remaining cross-process divergence vector). - install.sh persists data_dir/repos_dir into castle.yaml (idempotent, non-default). - Docs: registry.md globals + AGENTS.md roots. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
73 lines
2.3 KiB
Python
73 lines
2.3 KiB
Python
"""Apply (converge) API endpoint.
|
|
|
|
`POST /apply` reconciles the running system to match config — render units/
|
|
Caddyfile/tunnel, then activate/restart/deactivate to match. It replaces the old
|
|
`/deploy` (+ separate start/enable calls). `?plan=true` returns the diff without
|
|
touching anything.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from fastapi import APIRouter, HTTPException
|
|
from pydantic import BaseModel
|
|
|
|
from castle_core.config import CastleDirError
|
|
from castle_core.deploy import apply
|
|
|
|
router = APIRouter(tags=["apply"])
|
|
|
|
|
|
class ApplyRequest(BaseModel):
|
|
"""Optional request body for apply."""
|
|
|
|
name: str | None = None
|
|
plan: bool = False
|
|
|
|
|
|
class ApplyResponse(BaseModel):
|
|
"""The diff a converge enacted (or would enact, for a plan)."""
|
|
|
|
status: str
|
|
planned: bool
|
|
changed: bool
|
|
activated: list[str]
|
|
restarted: list[str]
|
|
deactivated: list[str]
|
|
unchanged: list[str]
|
|
messages: list[str]
|
|
|
|
|
|
@router.post("/apply", response_model=ApplyResponse)
|
|
def run_apply(request: ApplyRequest | None = None) -> ApplyResponse:
|
|
"""Converge the running system to match castle.yaml.
|
|
|
|
Renders systemd units + the Caddyfile + tunnel config, then reconciles the
|
|
runtime: activate enabled deployments that are down, restart any whose unit
|
|
changed, deactivate disabled ones. Pass a name to converge one deployment,
|
|
or `plan: true` to compute the diff without changing anything.
|
|
"""
|
|
name = request.name if request else None
|
|
plan = request.plan if request else False
|
|
|
|
try:
|
|
result = apply(target_name=name, plan=plan)
|
|
except FileNotFoundError as e:
|
|
raise HTTPException(status_code=404, detail=str(e)) from e
|
|
except CastleDirError as e:
|
|
# A fixable misconfiguration (e.g. data_dir points somewhere unwritable), not a
|
|
# server fault — return the actionable message so the dashboard can show it.
|
|
raise HTTPException(status_code=422, detail=str(e)) from e
|
|
except Exception as e:
|
|
raise HTTPException(status_code=500, detail=str(e)) from e
|
|
|
|
return ApplyResponse(
|
|
status="ok",
|
|
planned=result.planned,
|
|
changed=result.changed,
|
|
activated=result.activated,
|
|
restarted=result.restarted,
|
|
deactivated=result.deactivated,
|
|
unchanged=result.unchanged,
|
|
messages=result.messages,
|
|
)
|